Skip snapshotter root path creation for standalone convert mode#1906
Merged
Conversation
github-actions
Bot
added
go
sondavidb
reviewed
Mar 23, 2026
sondavidb
reviewed
Mar 24, 2026
Signed-off-by: Praful Gupta <prafulgupta6@gmail.com>
prafgup
force-pushed
the
prafulg/use-root-for-standalone
branch
from
cbf5cc9 to
49c51ce
Compare
Contributor
Author
|
@sondavidb Updated the PR with minimal changes just in main.go's Before hook. Also would appreciate if it could be possible for you to ask someone internally to review #1907 as well :) (ps. #1897 as well if possible, tho not required) |
sondavidb
approved these changes
Mar 24, 2026
Contributor
Author
|
Hey @Shubhranshu153 as you have the context :) can you please review this PR and the ones mentioned in #1906 (comment) |
coderbirju
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
soci convert --standalonefailing on minimal images (e.g., scratch with only/tmpor no dir) withmkdir /var/lib/soci-snapshotter-grpc/: no such file or directoryby skipping validation in main.Testing performed:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.